Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ember instance types for DANDI CLI #1565

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Jan 15, 2025

This should not merge until these endpoints actually exist, but may be helpful to the Ember team to have this as a draft anyway.

By adding an ember instance type (and ember-staging), the DANDI CLI should be able to be used as-is rather than requiring a custom PyPI.

#1517
#1527

By adding an ember instance type (and ember-staging), the DANDI CLI
should be able to be used as-is rather than requiring a custom PyPI.

dandi#1517
dandi#1527
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.32%. Comparing base (ba384c6) to head (a60e2b2).

❗ There is a different number of reports uploaded between BASE (ba384c6) and HEAD (a60e2b2). Click for more details.

HEAD has 95 uploads less than BASE
Flag BASE (ba384c6) HEAD (a60e2b2)
unittests 96 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1565       +/-   ##
===========================================
- Coverage   88.36%   68.32%   -20.05%     
===========================================
  Files          78       78               
  Lines       10735    10720       -15     
===========================================
- Hits         9486     7324     -2162     
- Misses       1249     3396     +2147     
Flag Coverage Δ
unittests 68.32% <ø> (-20.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandi/consts.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants