Create GitHub Actions workflows to build and push Docker Images

[kabilar]

Fix #141

• Add GitHub Actions workflow to test the image builds upon pull request
• Add GitHub Actions workflow to build and push to Docker Hub upon merge to main
  • Use existing DOCKERHUB_TOKEN and DOCKERHUB_USERNAME GitHub Actions secrets
  • Rename Dockerfile tag from latest to latest-base
  • Confirm that the images build on my fork and push to my Docker Hub. See successful GitHub Actions run and Docker Hub.
• Disable Build configuration on Docker Hub since we will now be pushing from GitHub

cc @satra

[satra]

overall looks good to me. it may be good to see if the build caches so that we don't rebuild all each time this workflow is run.

[asmacdo]

LGTM

I don't think it will do any build caching since it will fire up a totally fresh instance each push. That shouldn't be a problem for dockerhub if the builds are deterministic, but it probably will waste some power.

IIUC these images don't actually make use of anything in the repo other than the Dockerfiles themselves, so maybe something like...

on:
  push:
    paths:
      - 'Dockerfile.*'

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-including-paths

[kabilar]

overall looks good to me. it may be good to see if the build caches so that we don't rebuild all each time this workflow is run.

Good idea. I was able to add a caching mechanism. For reference, here are the docs:

• https://docs.docker.com/build/cache/backends/inline/
• https://docs.docker.com/build/ci/github-actions/cache/

[kabilar]

IIUC these images don't actually make use of anything in the repo other than the Dockerfiles themselves, so maybe something like...

Good idea. I have added the paths filter to both workflows.

[kabilar]

Proceeding with the merge here since all suggestions have been addressed.

[kabilar]

Hi @asmacdo, did you set an expiration date on Docker Hub for the DOCKERHUB_TOKEN secret? I was able to successfully run the Build Docker Images workflow but the Build and Push Docker Images failed with the following error (link):

#19 ERROR: failed to push ***/dandihub:latest-matlab: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3A***%2Fdandihub%3Apull%2Cpush&service=registry.docker.io: 401 Unauthorized

If the token is expired, I can replace the current one. Thanks.

[asmacdo]

@kabilar I used a repo specific key, you'll need a new one.

[kabilar]

Thanks @asmacdo.

All images have been built and pushed to Docker Hub. See latest GA run and images on Docker Hub.

cc @satra

[satra]

@kabilar - thank you. as part of this should we disable autobuilds on dockerhub?

[kabilar]

Hi @satra, I disabled the autobuilds on dockerhub.

I have noticed an issue with the GA builds. Only the images/Dockerfile is being built for all entries in matrix strategy. Trying to resolve now.