Fix invited user registration without SMTP #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-garcia
reviewed
Apr 4, 2025
There was a problem hiding this comment.
LGTM, just one duplicate if with the move.
We can consider changing the email sending from user.is_none() to user.is_none() || user.password_hash.is_none(), which should allow resending registration emails to users that are invited but not registered yet. Is that what you're thinking about?
Timshel
force-pushed
the
fix/registration
branch
from
3c9507b to
e54a7af
Compare
Sorry about that :(. For the resending was thinking of sending it in all cases but your suggestion is way better since it will prevent abuse. Hope you don't mind used the |
dani-garcia
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform the user check only if verification email is used.
It was blocking the registration of invited user when email was disabled.
Edit: I wonder if it would not make sense to just always send the email ?
It does create an unintuitive flow if the user already exists since it will fail later on, but currently it means that if the user has deleted the email he has no way to verify his email anymore.