b/390177544 cart: Support dynamic mercury/libfabric loglevels (#15738) #16077
+248
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mercury and libfabric are much too spammy to enable at lower than warning level by default. Mercury does support adjustment of its log level and logged subsystems at runtime, so this patch provides access to that functionality from the existing `dmg server set-logmasks` tool. This version of the patch adds support for writing DEBUG logs to a separate file in order to avoid problems with log ingestion pipelines that may be overwhelmed by the volume of DEBUG-level logging. To enable a standalone debug log, set the environment variable D_LOG_DEBUG_FILE to a path on disk where debug logs will be written. The log size and rotation behavior set for the main log file will be also applied to the debug log. To enable debug logging for just the mercury/libfabric libraries: dmg server set-logmasks -m EXTERNAL=DEBUG To disable debug logging again: dmg server set-logmasks -m EXTERNAL=ERR Change-Id: I667ed105545f3da717cb79ca07ae904673121d4b Signed-off-by: Michael MacDonald <mjmac@google.com>
|
Errors are Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data |
jolivier23
previously approved these changes
Mar 11, 2025
Signed-off-by: Michael MacDonald <mjmac@google.com>
jolivier23
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mercury and libfabric are much too spammy to enable at lower
than warning level by default. Mercury does support adjustment
of its log level and logged subsystems at runtime, so this
patch provides access to that functionality from the
existing
dmg server set-logmaskstool.This version of the patch adds support for writing DEBUG logs to
a separate file in order to avoid problems with log ingestion
pipelines that may be overwhelmed by the volume of DEBUG-level
logging. To enable a standalone debug log, set the environment
variable D_LOG_DEBUG_FILE to a path on disk where debug logs
will be written. The log size and rotation behavior set for
the main log file will be also applied to the debug log.
To enable debug logging for just the mercury/libfabric libraries:
dmg server set-logmasks -m EXTERNAL=DEBUG
To disable debug logging again:
dmg server set-logmasks -m EXTERNAL=ERR
Change-Id: I667ed105545f3da717cb79ca07ae904673121d4b
Signed-off-by: Michael MacDonald mjmac@google.com