-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GA to Lint + Format MegaBlocks #131
Conversation
I addressed all of your comments @b-chu except for taking care of fixing the All the tests pass, so it seems like this isn't such a bad issue... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the init files. Names should definitely match
I also added a contributing guide, style guide, and Pull_REQUEST template, all initially taken from composer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change license to Databricks
? Otherwise LGTM, would also like @b-chu to approve since large PR
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
…blocks into eitan-pre-commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix all your file headers
@mihir-db I changed the license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This PR lints and formats MegaBlocks. Specifically, we:
.pre-commit-config.yaml
with all of the same hooks as composer except forpyright
(will be done in a subsequent PR).pre-commit
hooks. Changes includeNote: I made all the
.sh
files in theexp
directory executable as per thecheck-executables-have-shebangs
hook.