Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove sys.path[0]. #2055

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

zuckerruebe
Copy link
Contributor

Fixes #2053.

@zuckerruebe
Copy link
Contributor Author

Hi @davidhalter

Continuing our discussion in #2053, it seems just deleting the del sys.path[0] line passes the tests. Whether you want to go with the safer "only delete first entry if it's the empty string" only you can decide...

@davidhalter
Copy link
Owner

Thanks. I feel like this is fine. Time will tell if there are going to be issues, but it definitely does not look necessary anymore in the general case.

@davidhalter davidhalter merged commit c4f0538 into davidhalter:master Mar 14, 2025
147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run subprocess with "non-standard" sys.path.
2 participants