Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated help text and added commit ID to the version information #15

Merged
merged 6 commits into from
Feb 8, 2025

Conversation

mike632t
Copy link
Contributor

@mike632t mike632t commented Feb 5, 2025

See what you think.

Note - To save disk space removed the test programs so you may want to be selective when merging these changes.

The help text has been reworked slightly, and I changed the error messages to use a display a brief message describing the command usage.

Two new command options (-? and -V) can be used to display the help test and version respectively and the code now checks for the -C option before converting the options to lower case.

The commit id is generated using the command git log -1 HEAD --format=%h when the code is compiled.

@davidly
Copy link
Owner

davidly commented Feb 6, 2025

The automated build in github using mr.bat is failing with invalid command. Can you please take a look and resolve this? Thanks! The other changes look good.

@mike632t
Copy link
Contributor Author

mike632t commented Feb 6, 2025

Not sure if I have fixed it (I don't actually have a Windows machine I can test it on) but it says awaiting approval so I think it has got past the automated build test?

@davidly
Copy link
Owner

davidly commented Feb 7, 2025

Hmm. Failing in a new way now.
ntvcm.cxx
ntvcm.cxx(2912): error C3688: invalid literal suffix 'd90'; literal operator or literal operator template 'operator ""d90' not found
ntvcm.cxx(2912): warning C4473: 'printf' : not enough arguments passed for format string
ntvcm.cxx(2912): note: placeholders and their parameters expect 4 variadic arguments, but 3 were provided
ntvcm.cxx(2912): note: the missing variadic argument 4 is required by format string '%s'
ntvcm.cxx(3079): warning C4244: '=': conversion from 'int' to 'char', possible loss of data
x80.cxx
Error: Process completed with exit code 2.

@mike632t
Copy link
Contributor Author

mike632t commented Feb 7, 2025

I'm afraid I've given up trying to pass the commit id from a batch script as I can't test it. I think that COMMIT_ID is being defined but does not have a value. As a result there are not enough parameters for the printf() statement...

@davidly davidly merged commit 4c0d5e7 into davidly:main Feb 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants