fix: grouping not updating token metadata correctly

src/components/InitiativeList/InitiativeSubListSubItem.tsx

@@ -71,7 +71,7 @@ const InitiativeSubListSubItem: React.FC<{
     if (newNameCopy !== tokenCopy.name) {
       if (!newNameCopy) newNameCopy = token.name
       tokenCopy.plainTextName = newNameCopy
-      Token.updateToken(tokenCopy)
+      Token.updateTokens([tokenCopy])
       setNewName(newNameCopy)
     }
     setIsEditingName(false)

src/components/OptionsList/GroupOptionsList.tsx

@@ -42,7 +42,7 @@ export const GroupOptionsList: React.FC<{
   const MAX_TURN_COUNT = 5
 
   useEffect(() => {
-    setSplitCount(tokens.length >= 5 ? 5 : 1)
+    setSplitCount(tokens.length > 5 ? 5 : 1)
   }, [subGroup])
 
   const handleNumberChange = (

src/obr/group.ts

@@ -217,7 +217,9 @@ export module Group {
       groupMetadata.groupsByType[subGroup.groupType].subGroupsById[subGroupId] =
         splitSubgroupsById[subGroupId]
     })
+
     await updateGroupMetadata(groupMetadata)
+    await Token.updateTokens(Object.values(subGroup.tokensById))
   }
 }
 
@@ -319,6 +321,7 @@ function proximityBasedSplittingAlgorithm(
       }
 
       group.forEach(token => {
+        token.tokenMetadata.subGroupId = subGroupId
         newSubGroup.tokensById[token.id] = token
       })
 
@@ -484,6 +487,7 @@ function hierarchicalClusteringSplittingAlgorithm(
     }
 
     cluster.tokens.forEach(token => {
+      token.tokenMetadata.subGroupId = subGroupId
       newSubGroup.tokensById[token.id] = token
     })
 
@@ -545,6 +549,7 @@ function randomSplittingAlgorithm(
       }
 
       group.forEach(token => {
+        token.tokenMetadata.subGroupId = subGroupId
         newSubGroup.tokensById[token.id] = token
       })
 

src/obr/tokens.ts

@@ -86,7 +86,27 @@ export namespace Token {
     })
   }
 
-  export const updateToken = (token: Token): void => {
+  export const updateTokens = (token: Token[]): void => {
+    const tokenMap = new Map<string, Token>()
+    for (const t of token) {
+      tokenMap.set(t.id, t)
+    }
+
+    OBR.scene.items.updateItems(
+      token.map(token => token.id),
+      items => {
+        if (items.length === 0) return
+        for (const item of items) {
+          const token = tokenMap.get(item.id)
+          if (!token) return
+          ;(item as Image).text.plainText = token.plainTextName
+          ;(item as Image).metadata[TOKEN_METADATA_ID] = token.tokenMetadata
+        }
+      },
+    )
+  }
+
+  export const updateTokenMetadata = (token: Token): void => {
     OBR.scene.items.updateItems([token.id], items => {
       if (items.length === 0) return
       ;(items[0] as Image).text.plainText = token.plainTextName