Skip to content

removed redundant and snapshot from Wal::BasicEncoder #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: pp
Choose a base branch
from
Open

removed redundant and snapshot from Wal::BasicEncoder #74

wants to merge 1 commit into from

Conversation

cherep58
Copy link
Collaborator

Optimized BasicEncoder::encode_segment function by removing std::unique_ptr<Redundant> from return value.
Performance test:
With returning redundant: ~9ms
Without returning redundant: ~5ms

@cherep58 cherep58 added the enhancement New feature or request label Apr 28, 2025
@cherep58 cherep58 requested review from u-veles-a and gshigin April 28, 2025 11:16
@cherep58 cherep58 self-assigned this Apr 28, 2025
@cherep58 cherep58 requested a review from vporoshok as a code owner April 28, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u-veles-a u-veles-a Awaiting requested review from u-veles-a

@gshigin gshigin Awaiting requested review from gshigin

@vporoshok vporoshok Awaiting requested review from vporoshok vporoshok is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@cherep58 cherep58

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cherep58