New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] Add data wipe #103

Draft

duckhawk wants to merge 52 commits into main from add-data-wipe

+281 −23

Member

duckhawk commented Feb 18, 2025 •

edited by asergunov

Loading

Description

Added the ability to delete data from volumes upon deletion in the EE edition.

What is the expected result?

Working feature of data wipe while deleting persistentVolumes

Checklist

Update version of sds-node-configurator after merging Thin data wipe sds-node-configurator#129
The code is covered by unit tests.
e2e tests passed.
Documentation updated according to the changes.
Changes were tested in the Kubernetes cluster manually.

duckhawk force-pushed the add-data-wipe branch from e2a2c8c to e7d08ef Compare

February 18, 2025 12:39

duckhawk self-assigned this

duckhawk requested a review from AleksZimin

February 19, 2025 12:36

duckhawk added the enhancement label

duckhawk changed the title ~~Add data wipe feature~~ [controller] Add data wipe

denmaloyreb reviewed

View reviewed changes

crds/localstorageclass.yaml Outdated Show resolved Hide resolved

crds/doc-ru-localstorageclass.yaml Outdated Show resolved Hide resolved

asergunov reviewed

View reviewed changes

crds/doc-ru-localstorageclass.yaml Outdated Show resolved Hide resolved

asergunov reviewed

View reviewed changes

crds/localstorageclass.yaml Outdated Show resolved Hide resolved

denmaloyreb previously approved these changes

View reviewed changes

AleksZimin dismissed denmaloyreb’s stale review via

53db9e8

February 21, 2025 11:58

AleksZimin reviewed

View reviewed changes

lib/go/common/pkg/feature/const_se.go Outdated Show resolved Hide resolved

AleksZimin reviewed

View reviewed changes

lib/go/common/pkg/feature/const_seplus.go Outdated Show resolved Hide resolved

AleksZimin marked this pull request as ready for review

February 21, 2025 12:21

AleksZimin requested a review from astef

February 21, 2025 12:30

AleksZimin previously approved these changes

View reviewed changes

astef requested changes

View reviewed changes

images/sds-local-volume-csi/src/driver/controller.go Outdated Show resolved Hide resolved

images/sds-local-volume-csi/src/pkg/utils/func.go Show resolved Hide resolved

images/sds-local-volume-csi/src/pkg/utils/func.go Outdated Show resolved Hide resolved

images/sds-local-volume-csi/src/pkg/utils/func.go Outdated Show resolved Hide resolved

duckhawk dismissed AleksZimin’s stale review via

0ae0595

February 25, 2025 18:45

duckhawk requested review from astef, asergunov, AleksZimin and denmaloyreb

March 6, 2025 04:44

asergunov requested changes

View reviewed changes

crds/localstorageclass.yaml Outdated Show resolved Hide resolved

docs/README.md Show resolved Hide resolved

api/v1alpha1/local_storage_class.go Outdated Show resolved Hide resolved

images/sds-local-volume-csi/src/driver/controller.go Outdated Show resolved Hide resolved

duckhawk marked this pull request as draft

March 6, 2025 08:15

krpsh123 and others added 7 commits

March 7, 2025 12:28


          [csi] Add a separate ServiceAccount for the csi-node (#104)

707cdb9

Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Add data wipe feature

733c46e

Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

b02f95f

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

5e7af31

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

e09e1b1

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

e576750

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>

Denis.Rebenok and others added 19 commits

March 7, 2025 12:29


          docs: fix crds: volumeCleanup parameter

72fd5d8

Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          docs: add Selects the method to clean the volume before deleting the …

d4a6484

…PV section in readme

Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

77fb3b2

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

a39ab90

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>

fix

0151c04

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Apply suggestions from code review

db69c7f

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

a7af321

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>

fix

8289f35

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>

fix

24990b8

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

a17d614

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Add storage class param pass

29994a2

Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Fix in volume creation

71bd8d0

Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Merge branch 'main' into add-data-wipe

bff587e

Signed-off-by: Vasily Oleynikov <vasily.oleynikov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

6fa49c7

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>

60f15a4

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          update crds

1020f1e

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          Updates to match sds-node-configurator

b5a568b

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>

asergunov force-pushed the add-data-wipe branch from 0ebdd18 to b5a568b Compare

March 7, 2025 06:31


          Merge branch 'main' into add-data-wipe

b325bf9

asergunov self-assigned this

asergunov self-requested a review

March 7, 2025 07:47


          new line at the end of file

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>

asergunov assigned duckhawk and unassigned duckhawk

asergunov marked this pull request as ready for review

March 7, 2025 11:16

asergunov marked this pull request as draft

March 7, 2025 11:17

asergunov added 2 commits

March 7, 2025 17:39


          Add thin to doc

15da091

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>


          fix fix

35ea6b0

Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels