Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: DH-18428: vscode-extension-tester e2e tests #223

Open
wants to merge 71 commits into
base: main
Choose a base branch
from

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Feb 28, 2025

DH-18428: vscode-extension-tester e2e tests

  • DH community server gets run via Docker in CI
  • VS code e2e tests run against the server
  • VS code Debug launch config for e2e tests
  • Tweaked the CI summaries to be less verbose in the Conversation content

Note, I plan to remove the old wdio tests in a separate PR since this one is already a bit large

Testing

CI

See CI builds for successful tests

Local

Locally, run npm run test:e2e

Debug

Note: To keep things more performant when iterating on tests, the debug config doesn't run all of the e2e setup such as downloading VS Code + Chromium. You'll need to run npm run test:e2e at least 1x before debugging.

  • Switch the debug launcher config to e2e Tests
  • Run the launch config

@bmingles bmingles force-pushed the DH-18428-2_e2e-vscode-extension-tester branch from 993a430 to d01421f Compare February 28, 2025 23:00
@bmingles bmingles changed the title DH-18428: vscode-extension-tester e2e tests ci: DH-18428: vscode-extension-tester e2e tests Mar 3, 2025
@bmingles bmingles marked this pull request as ready for review March 11, 2025 21:05
@bmingles bmingles requested a review from mofojed March 11, 2025 21:20
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

"report:junit2ctrf": "junit-to-ctrf test-reports/vitest.junit.xml --output test-reports/ctrf-report.json",
"report:prcomment": "mkdir -p ./pr-comment && cp $GITHUB_STEP_SUMMARY pr-comment/pr-comment.html",
"test:ci": "npm run compile && npm run test:lint && npm run test:unit",
"test:e2e": "npm run compile && cd e2e && wdio run ./wdio.conf.ts",
"test:e2e": "npm run build:ts && ./scripts/e2e.sh",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using && use concurrently. && isn't cross platform compatible.

Copy link
Collaborator Author

@bmingles bmingles Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be curious to understand what incompatibilities there may be, as I was under the impression this works on unix like environments and even in Windows CMD.

Also worth mentioning that this project already assumes you have to be in a Unix like environment that supports bash scripts, so maybe we are constrained in a way that incompatibilities don't apply?

If we do need to fix this, I'd propose we do it in another PR since && is already used in multiple places

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there was incompatibility with Windows cmd.exe, I may be incorrect about that. Had other issues with && though, see a previous change where I ran into issues with environment variables as part of the statements: https://github.com/deephaven-ent/iris/pull/1910

Co-authored-by: Mike Bender <mikebender@deephaven.io>
@bmingles bmingles requested a review from mofojed March 12, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants