-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: DH-18428: vscode-extension-tester e2e tests #223
base: main
Are you sure you want to change the base?
Conversation
993a430
to
d01421f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
"report:junit2ctrf": "junit-to-ctrf test-reports/vitest.junit.xml --output test-reports/ctrf-report.json", | ||
"report:prcomment": "mkdir -p ./pr-comment && cp $GITHUB_STEP_SUMMARY pr-comment/pr-comment.html", | ||
"test:ci": "npm run compile && npm run test:lint && npm run test:unit", | ||
"test:e2e": "npm run compile && cd e2e && wdio run ./wdio.conf.ts", | ||
"test:e2e": "npm run build:ts && ./scripts/e2e.sh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using &&
use concurrently
. &&
isn't cross platform compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be curious to understand what incompatibilities there may be, as I was under the impression this works on unix like environments and even in Windows CMD.
Also worth mentioning that this project already assumes you have to be in a Unix like environment that supports bash scripts, so maybe we are constrained in a way that incompatibilities don't apply?
If we do need to fix this, I'd propose we do it in another PR since &&
is already used in multiple places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought there was incompatibility with Windows cmd.exe, I may be incorrect about that. Had other issues with &&
though, see a previous change where I ran into issues with environment variables as part of the statements: https://github.com/deephaven-ent/iris/pull/1910
Co-authored-by: Mike Bender <mikebender@deephaven.io>
DH-18428: vscode-extension-tester e2e tests
Note, I plan to remove the old wdio tests in a separate PR since this one is already a bit large
Testing
CI
See CI builds for successful tests
Local
Locally, run
npm run test:e2e
Debug
e2e Tests