change listening to all ip address type for some NIC name not start w… #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith en eth,bond, except for the Unix type fixes:deepseek-ai#234 Signed-off-by: lizhipeng <lizhipeng@kylinos.cn>
|
some RDMA NIC name not start with en bond , no rules ,so mabybe needs to remove the rule . |
|
some like p1* |
SF-Zhou
reviewed
Apr 28, 2025
| @@ -65,7 +59,7 @@ Result<Void> Listener::setup() { | |||
|
|
|||
| auto &filters = config_.filter_list(); | |||
| for (auto [name, addr] : nics.value()) { | |||
| if (addr.up && (filters.empty() || filters.count(name) != 0) && checkNicType(name, networkType_)) { | |||
| if (addr.up && (filters.empty() || filters.count(name) != 0) && checkNicType(networkType_)) { | |||
There was a problem hiding this comment.
consider deleting the checkNicType function and replacing checkNicType(networkType_) with networkType_ != Address::UNIX
There was a problem hiding this comment.
networkType_ is not get from IfAddrs::load(), funny
There was a problem hiding this comment.
in this case ,this fun post "RDMA" to networkType_, NIC only filter by name
qiuxinyidian
commented
Apr 28, 2025
| @@ -30,18 +30,12 @@ | |||
|
|
|||
| namespace hf3fs::net { | |||
|
|
|||
| static bool checkNicType(std::string_view nic, Address::Type type) { | |||
There was a problem hiding this comment.
inetworkType_ is not get from load (), this fun post "RDMA" to networkType_, this case , NIC only filter by name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ith en eth,bond, except for the Unix type
fixes:#234