This repository was archived by the owner on Nov 30, 2021. It is now read-only.
WIP: declare "off_cluster_minio" #857
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for an External minio server using s3.accesskey and s3.secretkey,
will add s3.regionendpoint later
WIP: to resolve #481
More changes will go in deis/builder deis/controller deis/database
deis/registry, all of which have dependencies on s3/swift storage
In PoC I overrode DEIS_MINIO_SERVICE_HOST and DEIS_MINIO_SERVICE_PORT
I'd like to use that shortcut and it seems safe, but I'm open to doing it another way if it's cleaner. I would decompose host and port from value in s3.regionendpoint, reorganizing values.yaml so the off-cluster minio configuration is very obvious.
I could not reliably use Deis Workflow on any of my (relatively not-top-of-the-line) portable machines via minikube or minishift without adding a remote storage server for minio, and adding some persistent disk. Can we get the configuration for this mode worked out in 2.19 final release?