Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

head changes #199

Merged
merged 1 commit into from
Oct 18, 2023
Merged

head changes #199

merged 1 commit into from
Oct 18, 2023

Conversation

jtmst
Copy link
Contributor

@jtmst jtmst commented Oct 18, 2023

Description

Relates to #15510.

Changes
Adds various elements to the Head component in the _document file
Adds some icon and image files to next-build public/img directory

Testing done

local testing

Screenshots

image

QA steps

Verify that existing pages still build as expected
verify that favicon now renders properly
verify that appropriate files are loaded in network tab via their respective environment

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 18, 2023 17:37 Destroyed
Copy link
Contributor

@tjheffner tjheffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes here all look good to me. favicon loads as expected.

i do notice some failed requests in the console log, it appears to be adding a port to certain requests, but i don't think that's a result of these changes / this PR's problem.

@tjheffner tjheffner merged commit 1aa0d42 into main Oct 18, 2023
3 checks passed
@tjheffner tjheffner deleted the 15510-head-updates branch October 18, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants