Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include swc for tugboat ci #207

Merged
merged 1 commit into from
Oct 19, 2023
Merged

include swc for tugboat ci #207

merged 1 commit into from
Oct 19, 2023

Conversation

tjheffner
Copy link
Contributor

@tjheffner tjheffner commented Oct 19, 2023

Description

Now that dependabot is checking for updates properly, the tugboat environments get mad because a package is downloaded on the main preview that would be overwritten:

2023-10-19T18:21:34.176Z - 653170dfc573c9cdb25da416# git -C /var/lib/tugboat merge --no-edit origin/dependabot/npm_and_yarn/tsconfig-paths-webpack-plugin-4.1.0
error: The following untracked working tree files would be overwritten by merge:
        .yarn/cache/@next-swc-linux-x64-gnu-npm-13.5.4-50b6e19919-8.zip
Please move or remove them before you merge.
Aborting

Updating yarnrc.yml to include glibc version when it downloads deps gets the correct packages installed.

I also removed the tsconfig-paths-webpack-plugin from our deps because storybook correctly integrates with typescript now, it's no longer needed.

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Tasks

Preview Give feedback

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 19, 2023 18:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 19, 2023 18:36 Destroyed
@tjheffner tjheffner enabled auto-merge (squash) October 19, 2023 18:53
@tjheffner tjheffner merged commit 5a6f1c1 into main Oct 19, 2023
3 checks passed
@tjheffner tjheffner deleted the update-deps-2 branch October 19, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants