Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16287 additional preview indicator #280

Merged
merged 8 commits into from
Dec 18, 2023

Conversation

tjheffner
Copy link
Contributor

@tjheffner tjheffner commented Dec 12, 2023

Description

Closes #16287.

Testing done

Locally, running yarn dev and the cms with ddev.

I enabled the feature flag for next preview, then checked a story node in various moderation states & revisions.

Screenshots

Published workflow state, no banner
Screenshot 2023-12-11 at 4 31 03 PM

Archived workflow state, says archived revision in banner
Screenshot 2023-12-11 at 4 29 01 PM

Draft workflow state, says draft revision in banner
Screenshot 2023-12-11 at 4 32 34 PM

In Review workflow state, says draft revision in banner
Screenshot 2023-12-11 at 4 35 41 PM

QA steps

  1. In one terminal window, running the CMS locally with ddev start (main branch is fine)
  2. In a separate terminal window, in the next-build repo use this branch and start yarn dev
  3. In the local CMS, enable the FEATURE_NEXT_STORY_PREVIEW feature flag
  4. Visit any Story published node, check the preview link. Top banner should not be present.
  5. Edit the Story, set the workflow state to Draft
  6. Check the preview link, notice the top banner is present with draft revision
  7. Edit the Story again, set the workflow state to Archived
  8. Check the preview link, notice the top banner has changed to an archived revision

Tasks

Preview Give feedback

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 12, 2023 01:15 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 12, 2023 01:21 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 12, 2023 16:13 Destroyed
@tjheffner tjheffner marked this pull request as ready for review December 12, 2023 16:13
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 12, 2023 23:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 14, 2023 16:01 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2023 19:41 Destroyed
Copy link
Contributor

@jtmst jtmst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, lgtm!

@tjheffner tjheffner merged commit fb64af6 into main Dec 18, 2023
6 checks passed
@tjheffner tjheffner deleted the VACMS-16287-preview-indicator branch December 18, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS Preview should clearly indicate when a draft or archive is being previewed
3 participants