Redis fixin' + some small cleanup #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryguyk
reviewed
Jan 2, 2024
ryguyk
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #283, where I disabled redis because it was causing CMS tugboat preview servers to fail, as no redis service is available there (nor does it need to be, all preview pages should be fetched fresh). This re-enables redis using an env var. I pass it to the cli via
yarn exportonly, when static pages are generated.I also updated the generator template + terminal output to better reflect the slight refactor to queries in #306 .
Testing done
Verified redis did not run during
yarn dev, verified it does run & store menu keys duringyarn exportScreenshots
n/a
QA steps
Tasks