Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn deps #310

Merged
merged 11 commits into from
Jan 2, 2024
Merged

Fix yarn deps #310

merged 11 commits into from
Jan 2, 2024

Conversation

tjheffner
Copy link
Contributor

@tjheffner tjheffner commented Dec 29, 2023

Description

Cleaning up terminal output when running yarn or yarn install

Also removed the yarn cache step from the ci workflow. It wasn't being checked properly to begin with, but also caching in CI doesn't impact us much, as we include dependencies in the repo to begin with.

Testing done

Manually added some dependencies, set some already provided dependencies manually using yarn's packageExtensions

Screenshots

before:

yarn
➤ YN0000: ┌ Resolution step
➤ YN0002: │ @storybook/addon-controls@npm:7.6.3 doesn't provide react (p7cbd2), requested by @storybook/blocks
➤ YN0002: │ @storybook/addon-controls@npm:7.6.3 doesn't provide react-dom (p377dd), requested by @storybook/blocks
➤ YN0002: │ @storybook/manager-api@npm:7.6.3 doesn't provide react (pc38dd), requested by @storybook/theming
➤ YN0002: │ @storybook/manager-api@npm:7.6.3 doesn't provide react-dom (p3655f), requested by @storybook/theming
➤ YN0002: │ @types/testing-library__react@npm:10.2.0 doesn't provide react (p464c2), requested by @testing-library/react
➤ YN0002: │ @types/testing-library__react@npm:10.2.0 doesn't provide react-dom (p548ab), requested by @testing-library/react
➤ YN0060: │ next-build@workspace:. provides @fortawesome/fontawesome-free (pafbd5) with version 6.4.2, which doesn't satisfy what @department-of-veterans-affairs/formation requests
➤ YN0060: │ next-build@workspace:. provides @typescript-eslint/parser (p60a18) with version 5.62.0, which doesn't satisfy what @typescript-eslint/eslint-plugin requests
➤ YN0002: │ next-build@workspace:. doesn't provide i18next (p5e621), requested by @department-of-veterans-affairs/web-components
➤ YN0002: │ next-build@workspace:. doesn't provide i18next-browser-languagedetector (p04828), requested by @department-of-veterans-affairs/web-components
➤ YN0002: │ next-build@workspace:. doesn't provide playwright-core (pc7a33), requested by @axe-core/playwright
➤ YN0060: │ next-build@workspace:. provides react (pafd30) with version 18.2.0, which doesn't satisfy what @department-of-veterans-affairs/component-library and some of its descendants request
➤ YN0060: │ next-build@workspace:. provides react-dom (pd01e1) with version 18.2.0, which doesn't satisfy what @department-of-veterans-affairs/component-library and some of its descendants request
➤ YN0060: │ next-build@workspace:. provides uswds (pcd5d3) with version 2.14.0, which doesn't satisfy what @department-of-veterans-affairs/formation requests
➤ YN0002: │ next-drupal-query@npm:0.4.0 doesn't provide react (p229bb), requested by next
➤ YN0002: │ next-drupal-query@npm:0.4.0 doesn't provide react-dom (pe6eb5), requested by next
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 254ms
➤ YN0000: ┌ Link step
➤ YN0008: │ next-build@workspace:. must be rebuilt because its dependency tree changed
➤ YN0000: └ Completed in 1s 360ms
➤ YN0000: Done with warnings in 1s 929ms

after:

yarn
➤ YN0000: ┌ Resolution step
➤ YN0060: │ next-build@workspace:. provides @fortawesome/fontawesome-free (p1fa6a) with version 6.4.2, which doesn't satisfy what @department-of-veterans-affairs/formation requests
➤ YN0060: │ next-build@workspace:. provides react (pafd30) with version 18.2.0, which doesn't satisfy what @department-of-veterans-affairs/component-library and some of its descendants request
➤ YN0060: │ next-build@workspace:. provides react-dom (pd01e1) with version 18.2.0, which doesn't satisfy what @department-of-veterans-affairs/component-library and some of its descendants request
➤ YN0060: │ next-build@workspace:. provides uswds (p15d1f) with version 2.14.0, which doesn't satisfy what @department-of-veterans-affairs/formation requests
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 259ms
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed in 0s 348ms
➤ YN0000: Done with warnings in 0s 813ms

QA steps

Site should build properly without any errors.

Tasks

Preview Give feedback

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 29, 2023 19:35 Destroyed
ryguyk
ryguyk previously approved these changes Jan 2, 2024
alexfinnarn and others added 8 commits January 2, 2024 12:15
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2024 20:15 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2024 20:17 Destroyed
@tjheffner tjheffner merged commit 5f184e2 into main Jan 2, 2024
6 checks passed
@tjheffner tjheffner deleted the fix-yarn-deps branch January 2, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants