Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with formatting differences between GHA run and local linux #771

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

nfpappas-oddball
Copy link
Contributor

@nfpappas-oddball nfpappas-oddball commented Oct 2, 2024

Description

Fix deviaton in how successive if statements work in bash locally vs how they work in GHA runner

Developer Task

Tasks

Preview Give feedback

Testing Steps

Explain the steps needed for testing

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Screenshots

Before:
After:

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

Tasks

Preview Give feedback

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 20:18 Destroyed
@nfpappas-oddball nfpappas-oddball self-assigned this Oct 2, 2024
timcosgrove
timcosgrove previously approved these changes Oct 2, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 20:28 Destroyed
@nfpappas-oddball nfpappas-oddball merged commit ac0316b into main Oct 2, 2024
7 of 8 checks passed
@nfpappas-oddball nfpappas-oddball deleted the VAGOV-NB-sitemap-nullcheck branch October 2, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants