chore: removes _language-service command
#4220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-dfinity
force-pushed
the
christoph/remove-language-service
branch
from
c913995 to
900e5b1
Compare
3 tasks
christoph-dfinity
force-pushed
the
christoph/remove-language-service
branch
from
ff7b509 to
33d13a6
Compare
ggreif
changed the title
_language-service command
ggreif
reviewed
Apr 24, 2025
Co-authored-by: Gabor Greif <gabor@dfinity.org>
ggreif
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
dfx _language-servicecommand, as that runs the OCaml binary which is being removed as of dfinity/motoko#5075The OCaml based LS has been long superseded by a JS based one in the VSCode plugin: https://github.com/dfinity/vscode-motoko/tree/master/src/server
As the command was hidden from the UI I wouldn't characterize this as a breaking change, but I'll let you be the judge of that.
How Has This Been Tested?
Things continue to compile, searching project wide for
_language-servicedoes not bring up any results.Checklist: