-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge master into alpha [skip commit-lint] #28
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
dbb2126
Merge pull request #16 from dhis2/alpha
kabaros 7d3b7be
chore(release): cut 1.0.0-beta.22 [skip ci]
dhis2-bot ffa509a
fix: update useDatePicker hook to resolve options with hook
kabaros ad37d53
refactor: update fallback logic per code review comments
kabaros 09e4e07
refactor: make calendar default to gregory
kabaros 96226d6
Merge pull request #17 from dhis2/update-default-for-hooks
kabaros 98570f3
chore(release): cut 1.0.0-beta.23 [skip ci]
dhis2-bot 668f6d8
fix: update localisation logic for fixed period generation
kabaros a2e5277
Merge pull request #18 from dhis2/make-fix-period-locale-resilient
kabaros 897242c
chore(release): cut 1.0.0-beta.24 [skip ci]
dhis2-bot 6d93fd3
Merge pull request #19 from dhis2/beta
kabaros 9e1157d
chore(release): cut 1.0.0 [skip ci]
dhis2-bot 08c8032
fix: parse date correctly when a dhis2 calendar type is passed (#22)
kabaros 36dd66f
chore(release): cut 1.0.1 [skip ci]
dhis2-bot 3cfb58a
fix: use custom locale when it exists (#23)
kabaros 7305736
chore(release): cut 1.0.2 [skip ci]
dhis2-bot 3e347df
docs: update multi-calendar documentation (#25)
kabaros 1bae4fd
chore: merge branch 'main' into 'main->alpha'
Mohammer5 4dea52d
chore(gh verify commit workflow): add skip condition
Mohammer5 f72fbeb
fix: address merge issues (chore: merge branch 'main' into 'main->alp…
Mohammer5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
name: 'dhis2: verify (commits)' | ||
|
||
on: | ||
pull_request: | ||
types: ['opened', 'edited', 'reopened', 'synchronize'] | ||
|
||
jobs: | ||
lint-pr-title: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: c-hive/gha-yarn-cache@v1 | ||
- run: yarn install --frozen-lockfile | ||
- id: commitlint | ||
run: echo ::set-output name=config_path::$(node -e "process.stdout.write(require('@dhis2/cli-style').config.commitlint)") | ||
- uses: JulienKode/pull-request-name-linter-action@v0.5.0 | ||
with: | ||
configuration-path: ${{ steps.commitlint.outputs.config_path }} | ||
|
||
lint-commits: | ||
runs-on: ubuntu-latest | ||
if: ${{ !contains(github.event.pull_request.title, '[skip commit-lint]') }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- uses: c-hive/gha-yarn-cache@v1 | ||
- run: yarn install --frozen-lockfile | ||
- id: commitlint | ||
run: echo ::set-output name=config_path::$(node -e "process.stdout.write(require('@dhis2/cli-style').config.commitlint)") | ||
- uses: wagoid/commitlint-github-action@v4 | ||
with: | ||
configFile: ${{ steps.commitlint.outputs.config_path }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that there's an alpha h1 between this headline and the original # 1.0.0 headline, should be remain an h2 or should this be an h1 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, it should be h2 as it is