Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose methods for converting between iso8601 and calendars #37

Merged
merged 3 commits into from
May 27, 2024

Conversation

kabaros
Copy link
Collaborator

@kabaros kabaros commented May 23, 2024

Exposes two methods convertFromIso8601 and convertToIso8601 to convert between iso8601 and other calendars (ethiopic, nepali etc..).

Implements https://dhis2.atlassian.net/browse/LIBS-605

@kabaros kabaros force-pushed the date-conversion-update branch from 4d96fbd to e5a222b Compare May 23, 2024 10:55
@kabaros kabaros force-pushed the date-conversion-update branch 2 times, most recently from 5e37778 to f2ecc2e Compare May 27, 2024 11:06
@kabaros kabaros changed the title fix: allow non-standard calendar identifiers from dhis2 feat: expose methods for converting between iso8601 and calendars May 27, 2024
@kabaros kabaros marked this pull request as ready for review May 27, 2024 11:08
@kabaros kabaros force-pushed the date-conversion-update branch from f2ecc2e to 9787c1f Compare May 27, 2024 11:15
@kabaros kabaros force-pushed the date-conversion-update branch from 9787c1f to 3806e99 Compare May 27, 2024 11:16
@kabaros
Copy link
Collaborator Author

kabaros commented May 27, 2024

paired with @d-rita and @Chisomchima for this PR, with discussions including @abyot

Copy link

@d-rita d-rita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kabaros kabaros merged commit 33fa25d into alpha May 27, 2024
7 checks passed
dhis2-bot added a commit that referenced this pull request May 27, 2024
# [1.0.0-alpha.25](v1.0.0-alpha.24...v1.0.0-alpha.25) (2024-05-27)

### Features

* expose methods for converting between iso8601 and calendars ([#37](#37)) ([33fa25d](33fa25d))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Aug 28, 2024
# [1.3.0-alpha.1](v1.2.4...v1.3.0-alpha.1) (2024-08-28)

### Bug Fixes

* format undefined when thers is a mismatch ([79b54fd](79b54fd))
* remove unnecessary console warn ([b2d795d](b2d795d))

### Features

* expose function to convert dates ([622f0eb](622f0eb))
* expose function to convert dates ([9d42640](9d42640))
* expose methods for converting between iso8601 and calendars ([#37](#37)) ([33fa25d](33fa25d))
* reararnge memorized variables so that we only recompute them when necessary ([b754dcc](b754dcc))
* support min & max date, DD-MM-YYYY date format  ([#36](#36)) ([3b2e57e](3b2e57e))
* **validation:** add and expose validateDateString utility ([cb4c919](cb4c919))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Sep 24, 2024
# [1.3.0](v1.2.4...v1.3.0) (2024-09-24)

### Bug Fixes

* format undefined when thers is a mismatch ([79b54fd](79b54fd))
* localise validation message in multi calendar ([#61](#61)) ([ead860b](ead860b))
* remove unnecessary console warn ([b2d795d](b2d795d))

### Features

* expose function to convert dates ([622f0eb](622f0eb))
* expose function to convert dates ([9d42640](9d42640))
* expose methods for converting between iso8601 and calendars ([#37](#37)) ([33fa25d](33fa25d))
* reararnge memorized variables so that we only recompute them when necessary ([b754dcc](b754dcc))
* support min & max date, DD-MM-YYYY date format  ([#36](#36)) ([3b2e57e](3b2e57e))
* **validation:** add and expose validateDateString utility ([cb4c919](cb4c919))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants