Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add 'valid' property and update nepali validation logic #78

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

kabaros
Copy link
Collaborator

@kabaros kabaros commented Oct 8, 2024

No description provided.

@kabaros kabaros requested review from alaa-yahia and flaminic October 8, 2024 10:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (001d236) to head (537b7e2).
Report is 1 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha      #78      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.02%     
==========================================
  Files          56       56              
  Lines        1199     1197       -2     
  Branches      323      330       +7     
==========================================
- Hits         1095     1093       -2     
  Misses        102      102              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alaa-yahia alaa-yahia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue when strictValidation is set to false. In this case, the validation logic still returns an error instead of a warning

@kabaros kabaros merged commit 9fb353a into alpha Oct 9, 2024
7 checks passed
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants