fix(useDatePicker): fix onDateSelect type, export types #79
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaminic
approved these changes
Oct 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #79 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 56 56
Lines 1197 1197
Branches 328 330 +2
=======================================
Hits 1093 1093
Misses 102 102
Partials 2 2 ☔ View full report in Codecov by Sentry. |
kabaros
approved these changes
Oct 8, 2024
Birkbjo
force-pushed
the
fix/useDatePicker-types
branch
from
c424f6f to
5374d3f
Compare
dhis2-bot
added a commit
that referenced
this pull request
Oct 9, 2024
# [2.0.0-alpha.4](v2.0.0-alpha.3...v2.0.0-alpha.4) (2024-10-09) ### Bug Fixes * **useDatePicker:** fix onDateSelect type, export types ([#79](#79)) ([94358d2](94358d2))
|
🎉 This PR is included in version 2.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Nov 21, 2024
# [2.0.0](v1.3.2...v2.0.0) (2024-11-21) ### Bug Fixes * use export type ([#81](#81)) ([eaa8cdb](eaa8cdb)) * **useDatePicker:** fix onDateSelect type, export types ([#79](#79)) ([94358d2](94358d2)) * add 'valid' property to validation result ([894e181](894e181)) * remove Temporal references from hook public API and clean up use date picker ([#75](#75)) ([fb31512](fb31512)) * update validation logic to expose error code and mirror RFF format ([001d236](001d236)) * use NepaliCalendar instance to validate dates ([9fb353a](9fb353a)) ### BREAKING CHANGES * Remove Temporal references from hook public API * feat: remove validation details from result of useDatePicker as they are available in exposed validate date string function * feat: remove calendar date from use date picker * refactor: remove calendarDate from onDateSelect callback * refactor: remove zonedDateTime from week days array * refactor: fix linting issues
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to destructure the object in
onDateSelectcauses a runtime error, because it can be null (and isnullwhen usingclear-button in UI, that consumes this hook. I've updated the parameter type ofonDateSelectto include null. However I also noticed that the hooks actually just calls it with, excluding the
calendarDate. Should we update the type for the calendar to be optional, or the runtime code here?I've also exported the types, as it's convenient for consumers to be able to import types callback and options. Previously you would need to do something like
type UseDatePickerOptions = Parameters<typeof useDatePicker>[0]Note that the UI needs to update to the new version to get this propagated to UI-types, but it shouldn't require code changes in UI.