[fix][dingo-sdk] Correct unit testing errors

dingodb · Jan 10, 2025 · 67ab85e · 67ab85e
1 parent d0b792e
commit 67ab85e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/java/dingo-sdk/src/main/java/io/dingodb/sdk/common/AutoIncrement.java b/java/dingo-sdk/src/main/java/io/dingodb/sdk/common/AutoIncrement.java
@@ -46,6 +46,12 @@ public synchronized long inc() {
         return current;
     }
 
+    public synchronized void init() {
+        if (inc >= limit) {
+            fetch();
+        }
+    }
+
     public synchronized void inc(long targetInc) {
         if (targetInc > inc) {
             inc = targetInc;

diff --git a/java/dingo-sdk/src/main/java/io/dingodb/sdk/service/meta/AutoIncrementService.java b/java/dingo-sdk/src/main/java/io/dingodb/sdk/service/meta/AutoIncrementService.java
@@ -118,7 +118,7 @@ public void update(DingoCommonId tableId, long incrementId) {
             AutoIncrement autoIncrement = innerCache.computeIfAbsent(tableId,
                     id -> new AutoIncrement(id, increment, offset, this::fetcher));
             if (autoIncrement.getLimit() == 0) {
-                autoIncrement.inc();
+                autoIncrement.init();
             }
             if (incrementId < autoIncrement.getLimit() && incrementId >= autoIncrement.current()) {
                 autoIncrement.inc(incrementId);

diff --git a/java/dingo-sdk/src/test/java/sdk/common/serial/CodecTest.java b/java/dingo-sdk/src/test/java/sdk/common/serial/CodecTest.java
@@ -40,7 +40,7 @@ public void test() throws IOException {
         TableDefinition tableDefinition = TableDefinition.builder()
             .name("TEST_ENCODE")
             .columns(Arrays.asList(c1, c2, c3, c4))
-            .version(1)
+            .version(1).codecVersion(2)
             .build();
 
         DingoKeyValueCodec codec = DingoKeyValueCodec.of(1, 1L, tableDefinition);
@@ -60,13 +60,13 @@ public void testAdd() throws IOException {
         TableDefinition beforeTable = TableDefinition.builder()
             .name("TEST_BEFORE")
             .columns(Arrays.asList(c1, c2, c3))
-            .version(1)
+            .version(1).codecVersion(2)
             .build();
 
         TableDefinition afterTable = TableDefinition.builder()
             .name("TEST_AFTER")
             .columns(Arrays.asList(c1, c2, c3, c4))
-            .version(2)
+            .version(2).codecVersion(2)
             .build();
 
         Object[] beforeRecord = {"id1_1", true, 1.02};
@@ -98,13 +98,13 @@ public void testRemove() throws IOException {
         TableDefinition beforeTable = TableDefinition.builder()
             .name("TEST_BEFORE")
             .columns(Arrays.asList(c1, c2, c3, c4))
-            .version(1)
+            .version(1).codecVersion(2)
             .build();
 
         TableDefinition afterTable = TableDefinition.builder()
             .name("TEST_AFTER")
             .columns(Arrays.asList(c1, c2, c3))
-            .version(2)
+            .version(2).codecVersion(2)
             .build();
 
         Object[] beforeRecord = {"id1_1", true, 1.02, 123L};