Skip to content

Draft: Convert models to Json objects before result validation #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Draft: Convert models to Json objects before result validation #71

wants to merge 1 commit into from

Conversation

ptoussai
Copy link
Contributor

No description provided.

@ptoussai
Copy link
Contributor Author

ptoussai commented Jul 11, 2022 •
edited
Loading

This does not work with returns defined with a Model Type:

      returns: {
        type: 'ModelName'
      },

The error:

   "returns": [
      {
        "message": "must pass \"instanceof\" keyword validation",
        "keyword": "instanceof",
        "params": {}
      }
    ]

Edit: this is due to the default option useInstanceOf: true. However setting this to true is a breaking change.

@ptoussai ptoussai force-pushed the feature/fix-model-validation branch from 0916c83 to cfe505d Compare July 11, 2022 10:09
@lehni lehni force-pushed the master branch 2 times, most recently from b3a7781 to 0280cf0 Compare February 6, 2023 19:36
@lehni lehni force-pushed the master branch 4 times, most recently from 71a4b3b to 48ea431 Compare March 5, 2023 13:35
@lehni lehni force-pushed the master branch 7 times, most recently from fa0dc37 to 5e4ed7e Compare April 18, 2023 08:00
@lehni lehni force-pushed the master branch 4 times, most recently from 9b3348a to f0be91e Compare April 25, 2023 15:19
@lehni lehni force-pushed the master branch 9 times, most recently from 850f181 to a11c29f Compare May 1, 2023 20:23
@lehni lehni force-pushed the master branch 6 times, most recently from 5ffb83d to cbf3bb5 Compare May 17, 2023 14:45
@lehni lehni force-pushed the master branch 2 times, most recently from 233ffd3 to 68244db Compare July 26, 2023 08:52
@lehni lehni force-pushed the master branch 3 times, most recently from 05e9c05 to 9d4cad3 Compare September 15, 2023 13:38
@lehni lehni force-pushed the master branch 2 times, most recently from 1ee8961 to 10c26b8 Compare January 3, 2024 08:21
@lehni lehni force-pushed the master branch 3 times, most recently from e072746 to b030289 Compare April 8, 2024 23:12
@lehni lehni force-pushed the master branch 3 times, most recently from d2c408a to 0c579fd Compare April 26, 2024 20:06
@lehni lehni force-pushed the master branch 2 times, most recently from de9dfe4 to 4262212 Compare May 4, 2025 11:01
@lehni lehni closed this in 8a9a323 May 11, 2025
lehni added a commit that referenced this pull request May 11, 2025
@lehni
Convert models to Json objects before result validation
9699fbd 
Closes #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ptoussai