Skip to content

Add additional unit tests for appender string #10763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GalaxyRider111
Copy link

Adding some more additional unit test for string appender for the issue #8789 (#8789).

Comment on lines +311 to +314




Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition of whitespace here looks unnecessary.

Comment on lines +3804 to +3806



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please trim this to a single empty line between the two unittests. (No need for three of them.)

Comment on lines +3840 to +3844





Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please trim this to a single empty line between the unittest and the struct.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @GalaxyRider111! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10763"

@Herringway
Copy link
Contributor

There seems to be more than just unit tests in this PR.

@pbackus
Copy link
Contributor

pbackus commented May 14, 2025

  • Why does this PR contain both unit tests and functional changes, when the title and description only mention unit tests?
  • Why does this PR contain changes to both appender and std.container.array, when the title and description only mention appender?
  • What is the purpose of these changes? A PR description should explain why changes are being made, not just say what the changes are.

@GalaxyRider111
Copy link
Author

  • Why does this PR contain both unit tests and functional changes, when the title and description only mention unit tests?
  • Why does this PR contain changes to both appender and std.container.array, when the title and description only mention appender?
  • What is the purpose of these changes? A PR description should explain why changes are being made, not just say what the changes are.

Ok so, I'm sorry everyone, I have made a mistake. Initially, I added more unit tests for this PR. Then, I wanted to contribue to another issue, one that involves adding support for move-only types, and I have been working on this, hence the changes from std/container/array.d. Unfortunately, I kept working on the same branch as the one from this PR, my mistake, sorry for confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants