-
-
Notifications
You must be signed in to change notification settings - Fork 740
Add additional unit tests for appender string #10763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addition of whitespace here looks unnecessary.
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please trim this to a single empty line between the two unittests. (No need for three of them.)
|
||
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please trim this to a single empty line between the unittest and the struct.
Thanks for your pull request and interest in making D better, @GalaxyRider111! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10763" |
There seems to be more than just unit tests in this PR. |
|
Ok so, I'm sorry everyone, I have made a mistake. Initially, I added more unit tests for this PR. Then, I wanted to contribue to another issue, one that involves adding support for move-only types, and I have been working on this, hence the changes from std/container/array.d. Unfortunately, I kept working on the same branch as the one from this PR, my mistake, sorry for confusion. |
… the new unit tests from the std/array.d
Adding some more additional unit test for string appender for the issue #8789 (#8789).