fix(domain): restore error handling for network operations

[SJFCS]

Restore critical error checks for network
These checks are necessary to ensure proper error propagation when network operations fail.

Fixes #1091

Please make sure you read the contributor documentation before opening a Pull Request.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced error handling for retrieving network interface addresses, resulting in improved system resilience.
  • Adjusted the response to specific non-critical issues, allowing the process to continue smoothly under certain error conditions.

Description by Korbit AI

What change is being made?

Restore error handling for network operations by enhancing the logic to handle specific libvirt errors and removing verbose logging.

Why are these changes being made?

Previously, the code did not adequately handle certain error scenarios like an unresponsive agent, leading to potential operation failures. This improvement allows for specific libvirt errors to be caught and handled gracefully, ensuring robustness in network operations. Additionally, the removal of verbose logging tidies the output for better performance and readability.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[SJFCS]

1. In version 0.7.1, the domainGetIfacesInfo function has special logic for error handling.
   if an ErrAgentUnresponsive error is encountered when using qemu-agent to obtain an IP address, the code will ignore the error and continue trying, which gives qemu-agent time to start and respond.

switch virErr := err.(type) {
case libvirt.Error:
    // Agent can be unresponsive if being installed/setup
    if addrsrc == uint32(libvirt.DomainInterfaceAddressesSrcLease) && virErr.Code != uint32(libvirt.ErrOperationInvalid) ||
        addrsrc == uint32(libvirt.DomainInterfaceAddressesSrcAgent) && virErr.Code != uint32(libvirt.ErrAgentUnresponsive) {
        return interfaces, fmt.Errorf("Error retrieving interface addresses: %w", err)
    }
}

2. In the latest version（all version after 0.7.1）, error handling becomes simpler.
   any error will be returned directly, including ErrAgentUnresponsive, which causes qemu-agent to fail before it has fully started and responded.

if err != nil {
    return interfaces, fmt.Errorf("error retrieving interface addresses: %w", err)
}

This PR fixes this error handling.

Make the test cases mentioned issues/1091 pass.

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
libvirt/domain.go	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	✅

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ support@korbit.ai

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[dmacvicar]

Reworked it to use error.As to pass the linter.

Thanks for the PR. I am not sure why I removed that code path when fixing linting across the whole code back then.