This repository was archived by the owner on Mar 12, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 233
Using simpler oneliner for go vet #62
Open
arschles
wants to merge
1
commit into
dnephin:master
Choose a base branch
from
arschles:govet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2020
There have been a number of PRs opened to fix/improve the govet hook. My latest recommendation is here. If you want to run |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 18, 2021
8 tasks
mdelapenya
added a commit
to elastic/e2e-testing
that referenced
this pull request
Jan 19, 2021
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 19, 2021
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 19, 2021
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 19, 2021
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 19, 2021
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
mdelapenya
added a commit
to elastic/e2e-testing
that referenced
this pull request
Jan 19, 2021
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
mdelapenya
added a commit
to elastic/e2e-testing
that referenced
this pull request
Jan 19, 2021
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
mdelapenya
added a commit
to elastic/e2e-testing
that referenced
this pull request
Jan 19, 2021
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
mdelapenya
added a commit
to elastic/e2e-testing
that referenced
this pull request
Jan 19, 2021
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go vet check is failing in this PR (the logs are here). I'm not sure what's going on, but modern
go vet ./...
will run through all files in the repo. this is suboptimal, but it's not extremely slow in many cases. perhaps there should be two checks? just an idea, not sure if it's necessary