Compile with no-omit-frame-pointer

This adds support for profiling Python 3.12 and newer using Linux `perf` command. * https://docs.python.org/3.12/howto/perf_profiling.html Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
docker-library · Jan 17, 2025 · 5b0aadd · 5b0aadd
1 parent 0bb5f4b
commit 5b0aadd
Show file tree

Hide file tree

Showing 19 changed files with 81 additions and 0 deletions.
diff --git a/3.12/alpine3.20/Dockerfile b/3.12/alpine3.20/Dockerfile
diff --git a/3.12/alpine3.21/Dockerfile b/3.12/alpine3.21/Dockerfile
diff --git a/3.12/bookworm/Dockerfile b/3.12/bookworm/Dockerfile
diff --git a/3.12/bullseye/Dockerfile b/3.12/bullseye/Dockerfile
diff --git a/3.12/slim-bookworm/Dockerfile b/3.12/slim-bookworm/Dockerfile
diff --git a/3.12/slim-bullseye/Dockerfile b/3.12/slim-bullseye/Dockerfile
diff --git a/3.13/alpine3.20/Dockerfile b/3.13/alpine3.20/Dockerfile
diff --git a/3.13/alpine3.21/Dockerfile b/3.13/alpine3.21/Dockerfile
diff --git a/3.13/bookworm/Dockerfile b/3.13/bookworm/Dockerfile
diff --git a/3.13/bullseye/Dockerfile b/3.13/bullseye/Dockerfile
diff --git a/3.13/slim-bookworm/Dockerfile b/3.13/slim-bookworm/Dockerfile
diff --git a/3.13/slim-bullseye/Dockerfile b/3.13/slim-bullseye/Dockerfile
diff --git a/3.14-rc/alpine3.20/Dockerfile b/3.14-rc/alpine3.20/Dockerfile
diff --git a/3.14-rc/alpine3.21/Dockerfile b/3.14-rc/alpine3.21/Dockerfile
diff --git a/3.14-rc/bookworm/Dockerfile b/3.14-rc/bookworm/Dockerfile
diff --git a/3.14-rc/bullseye/Dockerfile b/3.14-rc/bullseye/Dockerfile
diff --git a/3.14-rc/slim-bookworm/Dockerfile b/3.14-rc/slim-bookworm/Dockerfile
diff --git a/3.14-rc/slim-bullseye/Dockerfile b/3.14-rc/slim-bullseye/Dockerfile
diff --git a/Dockerfile-linux.template b/Dockerfile-linux.template
@@ -198,6 +198,15 @@ RUN set -eux; \
 {{ if is_slim or is_alpine then ( -}}
 	LDFLAGS="${LDFLAGS:--Wl},--strip-all"; \
 {{ ) else "" end -}}
+{{
+	# Enabling frame-pointers only makes sense for Python 3.12 and newer as those have perf profiler support
+	if rcVersion | IN("3.9", "3.10", "3.11") then "" else (
+-}}
+# https://docs.python.org/3.12/howto/perf_profiling.html
+# But don't enable frame-pointers on 32bit x86 due to performance drop.
+# https://github.com/docker-library/python/pull/1000#issuecomment-2597021615
+	test "$gnuArch" != 'i686-linux-gnu' && EXTRA_CFLAGS="${EXTRA_CFLAGS:-} -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer"; \
+{{ ) end -}}
 	make -j "$nproc" \
 		"EXTRA_CFLAGS=${EXTRA_CFLAGS:-}" \
 		"LDFLAGS=${LDFLAGS:-}" \