-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add support for Docker network EnableIPv4 option with API 1.48 #3350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
0e08b1e
to
d857daf
Compare
I've force pushed to comply with Signed-off-by commit message. Is everything ok with the PR ? I saw some errors with the workflows but I'm not sure it's related to my changes. |
Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
I updated the test, and I also updated the version of Docker to use in order to use the minimum API version for the new feature. |
Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
Is everything OK for you with this PR ? (If a fix for dind-ssl tests is available, I can merge it in the PR) |
Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
Ok I've found a fix for the SSL tests. Everything should work now. |
Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
Do you want me to split this PR to separate the new feature and the bug fixes (and the SSL test) or do you prefer merging this PR all-in-one ? |
Adding support for EnableIPv4 for docker network with API 1.48 (source: https://docs.docker.com/reference/api/engine/version-history/#v148-api-changes)
Equivalent to the command option
docker network create --ipv4