Skip to content

Conversation

Dramelac
Copy link

Adding support for EnableIPv4 for docker network with API 1.48 (source: https://docs.docker.com/reference/api/engine/version-history/#v148-api-changes)

Equivalent to the command option docker network create --ipv4

Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
@Dramelac Dramelac force-pushed the network_enable_ipv4 branch from 0e08b1e to d857daf Compare August 18, 2025 12:01
@Dramelac
Copy link
Author

I've force pushed to comply with Signed-off-by commit message. Is everything ok with the PR ? I saw some errors with the workflows but I'm not sure it's related to my changes.

Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
@Dramelac
Copy link
Author

I updated the test, and I also updated the version of Docker to use in order to use the minimum API version for the new feature.
While I was at it, I took the opportunity to update the new syntax for .utcfromtimestamp(), which had been deprecated.

Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
@Dramelac
Copy link
Author

Is everything OK for you with this PR ?

(If a fix for dind-ssl tests is available, I can merge it in the PR)

Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
@Dramelac
Copy link
Author

Ok I've found a fix for the SSL tests. Everything should work now.
Let me know if you want me to create a dedicated PR for this fix.

Signed-off-by: Dramelac <dramelac@users.noreply.github.com>
@Dramelac Dramelac requested a review from kiview August 21, 2025 17:21
@Dramelac
Copy link
Author

Do you want me to split this PR to separate the new feature and the bug fixes (and the SSL test) or do you prefer merging this PR all-in-one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants