-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pre3] Blazor WASM fingerprinting and environment property #35057
base: main
Are you sure you want to change the base?
Conversation
@maraf ... To avoid a merge conflict in the What's New file, I'll just combine the coverage here. This PR now covers for Blazor WASM ...
I think I'm going to need more information tho ... what's happening with the |
That header doesn't exist any more, because of the |
I'm working on this now, and it's a bit tricky to explain without getting into implementation details. AFIACT, "hard" and "soft" fingerprinting aren't industry concepts. They seem to be convenient ways to describe implementation details of the framework. I'm trying to write this up without referring to them. Hopefully, I'll have this updated shortly, and then we can see just how badly 🙈 it has turned out 😆 ... and then try to fix it from there. |
This comment was marked as outdated.
This comment was marked as outdated.
The [Removed remarks] 🤔 I think I was overthinking what this needs to say. On the last commit, I placed my current understanding. See if that's at least headed in the right direction for module fingerprinting. ... actually the last two commits because I had to go back into the CSR reference docs and describe CSR for BWAs and CSR for standalone Blazor WebAssembly .......... well ...... my interpretations on them. We'll see where it's all going sideways when you look at it 🙈😆. |
@maraf ... I only found NIT updates to make this morning. AFAICT, we can avoid "hard" and "soft" fingerprinting details. I'm 👂 to learn if what's here is accurate. |
A rename is coming your way dotnet/sdk#47915 |
Update made. Let me know as soon as we can merge this. It's blocking other work just a little bit in terms of the What's New INCLUDE. Javier's Declaratively persist state updates are next and will touch the INCLUDE file. |
Now that I see the docs, the property |
I'll check it. |
btw ... There are 41 references to The problem with versioning all of the content for the boot file name change is that our versioning tools are weak for these types of large-scale changes (i.e., we don't have Version-by-file versioning 😢). It's best to take care of this on a different PR, so I've opened #35125 to address it after this PR is merged. |
This has the updates on it now. I split the BWA guidance from the standalone WASM guidance. |
Yes, it has and I'm questioning my choice :) It looks like all other places in Blazor don't have it
The rename will be preview4 |
😆I was wondering why you were asking me ... a goober docs dinosaur 🦖🙈🤣. I'm not much help when it comes to framework design. Having "Name" on it seems to line up OK with ... However, "Name" wasn't used for the environment property here ... And, it wasn't used for the And, it wasn't used for |
Fixes #35023
Addresses #34948
Addresses #34437
Fixes #35075
Covering two Blazor WASM features now on this PR ...
<WasmApplicationEnvironmentName>
to set the environmentInternal previews