Document BuildWithNetFrameworkHostedCompiler and friends #45620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
approved these changes
Apr 4, 2025
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
approved these changes
Apr 7, 2025
ViktorHofer
reviewed
Apr 8, 2025
Comment on lines
+865
to
+867
| ### RoslynUseMSBuildCompiler | ||
|
|
||
| `RoslynUseMSBuildCompiler=true` can be used to opt out of an implicit `RoslynUseSdkCompiler=true`. |
There was a problem hiding this comment.
Interesting. Why is this property necessary? Isn't setting <RoslynUseSdkCompiler>false</RoslynUseSdkCompiler> sufficient?
There was a problem hiding this comment.
Yes, it should be sufficient. RoslynUseMSBuildCompiler was documented by @jaredpar in https://github.com/dotnet/sdk/blob/main/documentation/general/decouple-vs-and-net-sdk.md that's why I included it in the implementation and here, but I agree it feels like we might not need it.
There was a problem hiding this comment.
Is that property already exposed? If not, I would probably remove it from this document and ideally from the implementation. Unless there's a reason why it needs to exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the pre-existing property BuildWithNetFrameworkHostedCompiler and two related properties that are being added in dotnet/sdk#48028.
Internal previews