Skip to content

Use PRAGMA defer_foreign_keys instead of PRAGMA foreign_keys when migrating #35873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use PRAGMA defer_foreign_keys instead of PRAGMA foreign_keys when migrating #35873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19ee6d5
Use `PRAGMA defer_foreign_keys` instead of `PRAGMA foreign_keys` when…
ferferga Mar 30, 2025
2b34d0d
Update tests for PRAGMA defer_foreign_keys
ferferga Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/EFCore.Sqlite.Core/Migrations/SqliteMigrationsSqlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ private IReadOnlyList<MigrationOperation> RewriteOperations(
if (rebuilds.Any())
{
operations.Add(
new SqlOperation { Sql = "PRAGMA foreign_keys = 0;", SuppressTransaction = true });
new SqlOperation { Sql = "PRAGMA defer_foreign_keys = ON;", SuppressTransaction = false });
}

foreach (var ((table, schema), _) in rebuilds)
Expand All @@ -458,12 +458,6 @@ private IReadOnlyList<MigrationOperation> RewriteOperations(
});
}

if (rebuilds.Any())
{
operations.Add(
new SqlOperation { Sql = "PRAGMA foreign_keys = 1;", SuppressTransaction = true });
}

foreach (var index in indexesToRebuild)
{
operations.Add(CreateIndexOperation.CreateFrom(index));
Expand Down
Loading