Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of typos #18439

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Fix a bunch of typos #18439

merged 1 commit into from
Apr 3, 2025

Conversation

bbatsov
Copy link
Contributor

@bbatsov bbatsov commented Apr 3, 2025

Description

Just a bunch of typo fixes here and there. (and some trailing whitespace, that got killed along the way)

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@bbatsov bbatsov requested a review from a team as a code owner April 3, 2025 07:07
Copy link
Contributor

github-actions bot commented Apr 3, 2025

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@bbatsov
Copy link
Contributor Author

bbatsov commented Apr 3, 2025

@dotnet-policy-service agree

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 3, 2025
@T-Gro T-Gro enabled auto-merge (squash) April 3, 2025 09:03
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Wonder how did this get in, we've done a typo cleanup not that long ago...

@T-Gro T-Gro merged commit 2598fb1 into dotnet:main Apr 3, 2025
33 of 34 checks passed
@bbatsov
Copy link
Contributor Author

bbatsov commented Apr 3, 2025

@psfinaki I noticed one type when I was reading something in the code and afterwards I thought it might be a good idea to run codespell on all the code. Those are not all of the typos it discovered, but I wanted to check if there's interest in such small fixes to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants