Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resumable and non-resumable CE error ranges #18450

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Apr 5, 2025

Description

BEFORE

Screenshot 2025-04-05 at 20 31 20

AFTER

open System.Threading.Tasks
let minimum () : Async<int> =
    async {
        let! batch = async { return 1 }
        return "1"
               ^^^
    }
    
let minimum () : Task<int> =
    task {
        let! batch = task { return 1 }
        return "1"
               ^^^
    }

Fixes #13789

Checklist

  • Test cases added
  • Release notes entry updated

Copy link
Contributor

github-actions bot commented Apr 5, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Apr 7, 2025

Updated the baselines locally and all test are passing. But the CI is not reflecting the same. Any tips @psfinaki ?

@psfinaki
Copy link
Member

psfinaki commented Apr 7, 2025

@edgarfgp yes :) I've checked out your branch.

The thing is that you're most likely running tests locally in the Debug mode (where they indeed pass) whereas the CI executes them in Release mode (where they fail locally as well). You're nearly there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Confusing type inference error in task expression
2 participants