[H/3] Clean up and fix Alt-Svc handling #114528
Open
+106
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Http/tests/UnitTests/Headers/HttpRequestHeadersTest.cs:277
- After re-adding the 'Alt-Svc' header with the value 'clear', consider adding an assertion to verify that the header was processed as expected, ensuring the roundtrip behavior is fully validated.
headers.Add("Alt-Svc", value);
| ExpireAltSvcAuthority(); | ||
| Debug.Assert(_authorityExpireTimer != null || _disposed); | ||
| _authorityExpireTimer?.Change(Timeout.Infinite, Timeout.Infinite); | ||
| break; | ||
| return; |
There was a problem hiding this comment.
Consider adding a clarifying comment above the 'return' statement to document that returning immediately upon handling a 'clear' Alt-Svc header is an intentional control flow decision to prevent further header processing.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
MihaZupan
approved these changes
Apr 11, 2025
| @@ -13,7 +13,9 @@ namespace System.Net.Http.Headers | |||
| /// </remarks> | |||
| internal sealed class AltSvcHeaderValue | |||
| { | |||
| public static AltSvcHeaderValue Clear { get; } = new AltSvcHeaderValue("clear", host: null, port: 0, maxAge: TimeSpan.Zero, persist: false); | |||
| public static string ClearString { get; } = "clear"; | |||
There was a problem hiding this comment.
Nit:
Suggested change
| public static string ClearString { get; } = "clear"; | |
| public const string ClearString = "clear"; |
No need respin CI just for this though.
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83775
Fixes #83874
ToStringfor "Alt-Svc: clear".HttpAuthoritycomparison by overloading==operator (class is internal, not public).