Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark InlineArrays as NonVersionable #114590

Merged
merged 1 commit into from
Apr 13, 2025

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Apr 12, 2025

It is safe to assume that the field layout of the recently introduced InlineArray helper types is never going to change. Marking the types as NonVersionable allows crossgen2 to omit CHECK_TYPE_LAYOUT fixup for these types.

It is safe to assume that the field layout of the recently introduced InlineArray helper types is never going to change. Marking the types as NonVersionable allows crossgen2 to omit CHECK_TYPE_LAYOUT fixup for these types.
@Copilot Copilot bot review requested due to automatic review settings April 12, 2025 07:37
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 12, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@jkotas
Copy link
Member Author

jkotas commented Apr 12, 2025

I have verified that the CHECK_TYPE_LAYOUT fixup is no longer emitted.

@jkotas jkotas added area-ReadyToRun-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 12, 2025
@jkotas jkotas requested a review from steveisok April 12, 2025 13:05
@jkotas jkotas merged commit d57c352 into dotnet:main Apr 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants