Fix missing cleanup of cached last used code heap #119204
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've started to hit a problem with the interpreter when a CodeHeap pointer obtained from the m_pLastUsedInterpreterDynamicCodeHeap was invalid. This issue is that we were missing cleanup of that cached code heap pointer when the code heap was destroyed. This change adds the cleanup in the same way it is done for non-interpreter dynamic code heap.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical memory safety issue in the CoreCLR interpreter where a cached code heap pointer remained valid after the underlying code heap was destroyed, leading to potential use-after-free scenarios.
- Adds proper cleanup of the cached interpreter dynamic code heap pointer when a code heap is removed
- Mirrors the existing cleanup pattern used for non-interpreter dynamic code heaps
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started to hit a problem with the interpreter when a CodeHeap pointer obtained from the m_pLastUsedInterpreterDynamicCodeHeap was invalid.
This issue is that we were missing cleanup of that cached code heap pointer when the code heap was destroyed.
This change adds the cleanup in the same way it is done for non-interpreter dynamic code heap.