Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions summary output fix #6272

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

erichiller
Copy link
Contributor

@erichiller erichiller requested a review from a team as a code owner October 21, 2023 12:44
Comment on lines 82 to 85
textWriter.WriteLine(
"summary-details<<EOF\n" +
summary +
"\nEOF\n" );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit picking on style 😁

I would think it would be better to do multiple write lines instead of a single with multiple lines, or use the interpolated string. This one is very clear as to the intent of the output:

textWriter.WriteLine("summary-details<<EOF");
textWriter.WriteLine(summary);
textWriter.WriteLine("EOF");

or this, which is less clear but a one-liner:

textWriter.WriteLine($"summary-details<<EOF\n{summary}\nEOF\n");

@IEvangelist ping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. Updated to use multiple testWriter.WriteLine. Let me know if there is anything else.

@IEvangelist IEvangelist merged commit 6d83421 into dotnet:main Oct 30, 2023
3 checks passed
@erichiller erichiller deleted the github-actions-summary-output-fix branch October 31, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants