Enable nullability in ToolboxItemSnapLineBehavior #13058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13058 +/- ##
===================================================
- Coverage 61.78295% 61.77720% -0.00575%
===================================================
Files 1552 1552
Lines 158950 158947 -3
Branches 14803 14802 -1
===================================================
- Hits 98204 98193 -11
- Misses 60030 60038 +8
Partials 716 716
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
LeafShi1
previously approved these changes
Mar 3, 2025
| SelectionManager selMgr = (SelectionManager)_serviceProvider.GetService(typeof(SelectionManager)); | ||
| if (selMgr is not null) | ||
| Adorner? bodyAdorner = null; | ||
| if (_serviceProvider.TryGetService(out SelectionManager? selMgr)) |
There was a problem hiding this comment.
Could you please use GetRequiredService here? Previously we were throwing a null reference exception when the selection manager was not available.
Tanya-Solyanik
added
the
waiting-author-feedback
|
@gpetrou - this PR is almost ready, is it OK with you if we take it over and finish up? |
gpetrou
force-pushed
the
ToolboxItemSnapLineBehavior
branch
from
9c9466c to
3ec1dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow