[release/9.0] Fixing Analyzer issues, servicing, Part 2: Actual Fixes #13182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlausLoeffelmann
force-pushed
the
FixAnalyzerIssues9.0Rel
branch
2 times, most recently
from
19e5925 to
fe3dd24
Compare
KlausLoeffelmann
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #13182 +/- ##
=====================================================
- Coverage 74.83821% 74.79265% -0.04557%
=====================================================
Files 3022 2997 -25
Lines 630460 629261 -1199
Branches 46797 46742 -55
=====================================================
- Hits 471825 470641 -1184
- Misses 155247 155258 +11
+ Partials 3388 3362 -26
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ionConfiguration. * Addresses 13205, 13206, 13207, 13208.
KlausLoeffelmann
force-pushed
the
FixAnalyzerIssues9.0Rel
branch
from
c6effd1 to
7b2aaa0
Compare
Tanya-Solyanik
added
area-Analyzers/CodeFixes
KlausLoeffelmann
added
the
🚫 * NO-MERGE *
| @@ -12,6 +12,7 @@ | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization> | |||
| <GenerateResourceWarnOnBinaryFormatterUse>false</GenerateResourceWarnOnBinaryFormatterUse> | |||
| <IsTestUtilityProject>true</IsTestUtilityProject> | |||
There was a problem hiding this comment.
Why is this property needed? Do we not set shipping/notshipping properties based on the Test suffix?
KlausLoeffelmann
changed the base branch from
release/9.0
to
servicing/RefactorAnalyzerTests9.0Rel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of servicing Analyzer fixes back to release/9.0.
This PR contains the actual fixes along with the added tests based on the back ported infrastructure from .NET 10.
See Part 1, Changing the Infrastructure, here:
#13072
Microsoft Reviewers: Open in CodeFlow
Please note, that these fixes have been done and checked, so the respective other language applied, both in C# and Visual Basic, and then Unit Tests had been added to cover those scenarios.
From here, once these are OK'ed, we will back-port them (again, if you will, because the originally came from .NET 10 main), to .NET 10, and the new Clipboard Analyzer's tests will then be updated to integrate into the new test infra.
And after that, they can go into main/net10.