-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage for StandardCommandToolStripMenuItem #13215
Add code coverage for StandardCommandToolStripMenuItem #13215
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13215 +/- ##
===================================================
+ Coverage 61.35135% 61.82138% +0.47003%
===================================================
Files 1547 1553 +6
Lines 158479 159000 +521
Branches 14751 14806 +55
===================================================
+ Hits 97229 98296 +1067
+ Misses 60548 59989 -559
- Partials 702 715 +13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces unit tests for StandardCommandToolStripMenuItem to improve code coverage by validating its public methods.
- Adds tests verifying property initialization through the constructor
- Includes tests for updating item properties via RefreshItem
- Checks that the Image property caches its value after the first access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a small comment, all LGTM!
....Design/tests/UnitTests/System/Windows/Forms/Design/StandardCommandToolStripMenuItemTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Related #10773
Proposed changes
Add unit test file: StandardCommandToolStripMenuItemTests.cs for public methods of the StandardCommandToolStripMenuItem.cs
Microsoft Reviewers: Open in CodeFlow