Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for ToolStripEditorManager #13218

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Apr 1, 2025

Related #10773

Proposed changes

Add unit test file: ToolStripEditorManagerTests.cs for public methods & Properties of the ToolStripEditorManager.cs

Original PR: #13094

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 95.08197% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.66903%. Comparing base (dafcdbf) to head (5a06a43).
Report is 30 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13218          +/-   ##
====================================================
+ Coverage   61.53701%   95.66903%   +34.13202%     
====================================================
  Files           1549         535        -1014     
  Lines         158620       62665       -95955     
  Branches       14759        1382       -13377     
====================================================
- Hits           97610       59951       -37659     
+ Misses         60308        2391       -57917     
+ Partials         702         323         -379     
Flag Coverage Δ
Debug 95.66903% <95.08197%> (+34.13202%) ⬆️
integration ?
production ?
test 95.66903% <95.08197%> (-0.00682%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed area-Infrastructure labels Apr 1, 2025
ricardobossan
ricardobossan previously approved these changes Apr 2, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback and removed waiting-review This item is waiting on review by one or more members of team labels Apr 3, 2025
@Tanya-Solyanik Tanya-Solyanik self-requested a review April 3, 2025 17:13
@ricardobossan ricardobossan dismissed Tanya-Solyanik’s stale review April 4, 2025 00:15

New comments need to be addressed

@ricardobossan ricardobossan dismissed their stale review April 4, 2025 22:26

New comments need to be addressed.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Apr 7, 2025
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit d7888a8 into dotnet:main Apr 8, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 8, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Apr 8, 2025
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_ToolStripEditorManager branch April 9, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants