Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-570] - Send basic auth header for webform submit #1422

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/SD-570

What I did

  • Only sends header when env vars are set to make sure it's backwards compatible

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@jeffdowdle jeffdowdle added this to the 2.24.0 milestone Jan 14, 2025
Copy link

cypress bot commented Jan 14, 2025

ripple-framework    Run #2499

Run Properties:  status check passed Passed #2499  •  git commit 1b64b60257: feat(@dpc-sdp/ripple-tide-webform): send basic auth for webform submit if provid...
Project ripple-framework
Branch Review feature/SD-570-webform-submit-auth
Run status status check passed Passed #2499
Run duration 10m 20s
Commit git commit 1b64b60257: feat(@dpc-sdp/ripple-tide-webform): send basic auth for webform submit if provid...
Committer Jeffrey Dowdle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 218
View all changes introduced in this branch ↗︎

@jeffdowdle jeffdowdle merged commit dc3a979 into release/2.24.0 Jan 15, 2025
6 checks passed
@jeffdowdle jeffdowdle deleted the feature/SD-570-webform-submit-auth branch January 15, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants