Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint #48

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Add ESLint #48

wants to merge 9 commits into from

Conversation

artnc
Copy link
Member

@artnc artnc commented Apr 3, 2025

Main new features, many of which are already enforced in our duolingo.com repo:

  • Sort object keys alphabetically
  • Collapse small object literals onto one line
  • Sort members within each import statement
  • Prefer { foo } instead of { foo: foo }
  • Prefer returning expression from arrow function instead of using block form
  • Name catch variables ex and omit if unused
  • Swap if and else branches to avoid unnecessary !
  • Use Record instead of { []: } form
  • Remove unnecessary async
  • Collapse short JSDoc onto one line

@artnc artnc force-pushed the add-eslint-for-import-sorting branch 3 times, most recently from 5c0f7e8 to e98629d Compare April 3, 2025 07:13
@artnc artnc changed the title Add ESLint for import sorting Add ESLint Apr 3, 2025
@artnc artnc force-pushed the add-eslint-for-import-sorting branch 3 times, most recently from 9b29b17 to f0b2de0 Compare April 4, 2025 05:50
@artnc artnc force-pushed the add-eslint-for-import-sorting branch 3 times, most recently from 2825297 to ac8efd8 Compare April 4, 2025 07:00
@artnc artnc force-pushed the add-eslint-for-import-sorting branch from ac8efd8 to 374dcfc Compare April 4, 2025 07:00
@artnc artnc force-pushed the add-eslint-for-import-sorting branch from 2aa25f9 to ac73262 Compare April 5, 2025 02:41
@artnc artnc force-pushed the add-eslint-for-import-sorting branch from 02a4b08 to 8fb588b Compare April 5, 2025 03:20
@artnc artnc force-pushed the add-eslint-for-import-sorting branch 9 times, most recently from 1c8d086 to f08c03f Compare April 6, 2025 06:33
@artnc artnc force-pushed the add-eslint-for-import-sorting branch 6 times, most recently from 3089d59 to 64c6cb5 Compare April 7, 2025 22:58
@artnc artnc force-pushed the add-eslint-for-import-sorting branch from 64c6cb5 to d77df39 Compare April 8, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant