#810 Add the possibility to zip the inputs and outputs for N simulation #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barondim
force-pushed
the
810_SA_add_the_possibility_zip_the_inputs_and_outputs
branch
from
cc022b3 to
abe282a
Compare
Signed-off-by: Dimitri Baron <dimitri.baron@rte-france.com>
barondim
force-pushed
the
810_SA_add_the_possibility_zip_the_inputs_and_outputs
branch
from
abe282a to
1826950
Compare
rosiereflo
requested changes
Jan 7, 2025
| "$MPIRUN_PATH" -np $NBPROCS $DYNAFLOW_LAUNCHER_INSTALL_DIR/bin/DynaFlowLauncher --log-level $DYNAFLOW_LAUNCHER_LOG_LEVEL \ | ||
| --network $2 \ | ||
| --config $3 \ | ||
| --contingencies $4 | ||
| fi | ||
| else | ||
| if [ -n "$ZIP_ARCHIVE" ]; then |
There was a problem hiding this comment.
Maybe we should add a check that the zip archive exists
There was a problem hiding this comment.
The check is made in the C++ code
There was a problem hiding this comment.
yes, but it is also the case for network, config and contingencies files and yet they are tested in the other branch. This is to be homogeneous
Signed-off-by: Dimitri Baron <dimitri.baron@rte-france.com>
rosiereflo
reviewed
Jan 9, 2025
|
|
||
|
|
||
| std::string formatZipErrorMessage(const zip::ZipException& e) { | ||
| std::stringstream zipErrorStream; |
There was a problem hiding this comment.
Why overriding the messages sent by libzip? The general exception catch should be enough ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes