Refactor Sisyphus to ts and drop unnecessary functionality #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 977a4ae)
hansegucker
force-pushed
the
refactor-sisyphus
branch
from
781b949 to
5421931
Compare
niklasmohrin
reviewed
Feb 3, 2025
Fixed. |
hansegucker
force-pushed
the
refactor-sisyphus
branch
from
3a1d1c4 to
559083b
Compare
Comment on lines
55
to
59
| if (this.options.name) { | ||
| this.href = this.options.name; | ||
| } else { | ||
| this.href = location.hostname + location.pathname; | ||
| } |
There was a problem hiding this comment.
So should we just rename AutoFormSaverOptions.name to href and make location.hostname + location.pathname the default?
hansegucker
force-pushed
the
refactor-sisyphus
branch
2 times, most recently
from
c97cc96 to
1a94a9a
Compare
hansegucker
force-pushed
the
refactor-sisyphus
branch
from
1a94a9a to
5baee13
Compare
richardebeling
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2371