-
-
Notifications
You must be signed in to change notification settings - Fork 14
Improve controller security, error handling and page layout #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
line-o
wants to merge
5
commits into
eXist-db:master
Choose a base branch
from
line-o:feat/controller-security-error-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve controller security, error handling and page layout #105
line-o
wants to merge
5
commits into
eXist-db:master
from
line-o:feat/controller-security-error-handling
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- footer sticks to the bottom of the window - improve module info display - info icon size and alignment - module info boottom and right margin - module description foont size - improve function info display - remove duplicate function name
- rewrite scan.xql to generate.xqm - adhere to naming conventions - explicitly allow routes and deny evertying else - route modules/reindex.xql moved to /regenerate - add routes fro markdown and static resources - call to /regenerate is a GET request
92297b3
to
a4b1876
Compare
- use new route `/exist/apps/fundocs/generate` - do not test for removed headline in function info - test for changed module name
a4b1876
to
ff5ee89
Compare
This was referenced Aug 3, 2025
dizzzz
approved these changes
Aug 17, 2025
duncdrum
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor suggestion
I see it is already in here :) Then we merge it and cut a new release which can go live on exist-db.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST /modules/reindex.xql
replaced withGET /regenerate
-- edit --
The todos in here were misleading. I will open issues with those enhancements we do at some point
Screenshots
Visual differences:
New on the left, old on the right