Skip to content

Commit

Permalink
Fix race condition when setting doorstop
Browse files Browse the repository at this point in the history
Use GameInstruction to only set vanillaLaunchArgs, and to not touch the
doorstopTarget, which should be set by the GameRunningProvider. This
way the doorstopTarget value shown on modal will actually match the
values that are used when the game is launched either as vanilla or as
modded by the GameRunner instance.
  • Loading branch information
anttimaki committed Jan 31, 2024
1 parent d2f0a1f commit ddb0ab0
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/pages/Manager.vue
Original file line number Diff line number Diff line change
Expand Up @@ -454,8 +454,7 @@ import CategoryFilterModal from '../components/modals/CategoryFilterModal.vue';
showLaunchParameters() {
if (this.contextProfile !== null) {
GameInstructions.getInstructionsForGame(this.activeGame, this.contextProfile).then(async instructions => {
this.doorstopTarget = instructions.moddedParameters;
GameInstructions.getInstructionsForGame(this.activeGame, this.contextProfile).then(instructions => {
this.vanillaLaunchArgs = instructions.vanillaParameters;
});
Expand Down

0 comments on commit ddb0ab0

Please sign in to comment.